Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement std::exception for MetadataError #532

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

implement std::exception for MetadataError #532

wants to merge 2 commits into from
+6 −1

Conversation

tlambert03
Copy link
Contributor

@tlambert03 tlambert03 commented Dec 1, 2024 •
edited
Loading

this adds a MetadataError::what(), and adds an overloaded MetadataKeyError(const char* key) constructor that will include the missing key in the exception error if provided

@marktsuchida
Copy link
Member

  • This change does not introduce incompatible changes to the MMCoreJ API.
  • This change does not affect the device interface ABI.
  • Increment MMCore minor version when merging.

We could also make MetadataError an actual subclass of std::exception if that helps with anything. Not doing that for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlambert03 @marktsuchida